provide default 'ReactJsExceptionHandler' when missing #44942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Making `ReactJsExceptionHandler` optional (using nullable) when passing into ReactHostImpl. Default implementation implemented in `ReactInstance.java` is provided when it is null. Default handler uses NativeExceptionHandler TurboModule to handle error. Changing existing implementation using an empty stub with `null` so default implementation can be utilized. Changelog: [Android][Added] Providing a default `ReactJsExceptionHandler` when `null` parameter is passed into `ReactHostImpl` constructor Differential Revision: D58558762
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58558762 |
Base commit: 8b53d41 |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Making
ReactJsExceptionHandleroptional (using nullable) when passing into ReactHostImpl. Default implementation implemented inReactInstance.javais provided when it is null. Default handler uses NativeExceptionHandler TurboModule to handle error.Changing existing implementation using an empty stub with
nullso default implementation can be utilized.Changelog: [Android][Added] Providing a default
ReactJsExceptionHandlerwhennullparameter is passed intoReactHostImplconstructorDifferential Revision: D58558762