Re-use Animation _nativeIds #45109
Open
Re-use Animation _nativeIds #45109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58770465 |
Base commit: f7fe688 |
|
This pull request was exported from Phabricator. Differential Revision: D58770465 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jun 23, 2024
Summary: Pull Request resolved: facebook#45109 Re-using _nativeIds should be perfectly safe. Tracking animations already re-use animation IDs when the value being tracked is updated. This change is in preparation for an exploratory API for triggering Animated actions on events (e.g., starting an animation on hover). Differential Revision: D58770465
|
This pull request was exported from Phabricator. Differential Revision: D58770465 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Jun 23, 2024
Summary: Pull Request resolved: facebook#45109 Re-using _nativeIds should be perfectly safe. Tracking animations already re-use animation IDs when the value being tracked is updated. This change is in preparation for an exploratory API for triggering Animated actions on events (e.g., starting an animation on hover). Differential Revision: D58770465
Summary: Pull Request resolved: facebook#45109 Re-using _nativeIds should be perfectly safe. Tracking animations already re-use animation IDs when the value being tracked is updated. This change is in preparation for an exploratory API for triggering Animated actions on events (e.g., starting an animation on hover). Differential Revision: D58770465
|
This pull request was exported from Phabricator. Differential Revision: D58770465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Re-using _nativeIds should be perfectly safe. Tracking animations already re-use animation IDs when the value being tracked is updated. This change is in preparation for an exploratory API for triggering Animated actions on events (e.g., starting an animation on hover).
Differential Revision: D58770465