Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector proxy: Add reactNative.openDebuggerPath to json/list responses #45136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

robhogan
Copy link
Contributor

Summary:
Adds a URL path (/open-debugger?some-query-params) for each of the debug targets listed by /list/json that may be used to trigger opening the debugger frontend via a POST to the inspector server.

Changelog:
[General][Added] Inspector: Add reactNative.openDebuggerPath to /json/list responses

Differential Revision: D58949662

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58949662

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58949662

robhogan added a commit to robhogan/react-native that referenced this pull request Jun 24, 2024
…onses (facebook#45136)

Summary:
Pull Request resolved: facebook#45136

Adds a URL path (`/open-debugger?some-query-params`) for each of the debug targets listed by `/list/json` that may be used to trigger opening the debugger frontend via a POST to the inspector server.

Changelog:
[General][Added] Inspector: Add reactNative.openDebuggerPath to /json/list responses

Differential Revision: D58949662
robhogan added 3 commits June 24, 2024 08:24
…n-debugger

Summary:
Previously, if the `/open-debugger` endpoint was provided with both `device` and `appId` query params, we would:
 - Try to find a target with a matching `device` (note that these logical "devices" are unique per-app) - if found, use it. Otherwise,
 - Try to find a target with a matching `appId` - if found, use that.

This could go "wrong" in two ways:
 - If a `device` is given with a spurious `appId`, we'd open to a target with an `appId` differing from the one specified.
 - If the `device` has gone away but there is a different target with the same app, we'd use that as a fallback (right app, wrong device).

This applies the filters more strictly so that if both are given, both must match.

Changelog:
[General][Changed]: Inspector: Enforce device and appId filters if both are given to /open-debugger

Differential Revision: D58951952
…acebook#45136)

Summary:
Pull Request resolved: facebook#45136

Adds a URL path (`/open-debugger?some-query-params`) for each of the debug targets listed by `/list/json` that may be used to trigger opening the debugger frontend via a POST to the inspector server.

Changelog:
[General][Added] Inspector: Add reactNative.openDebuggerPath to /json/list responses

Differential Revision: D58949662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58949662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants