-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspector proxy: Add reactNative.openDebuggerPath
to json/list responses
#45136
Open
robhogan
wants to merge
3
commits into
facebook:main
Choose a base branch
from
robhogan:export-D58949662
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D58949662 |
This pull request was exported from Phabricator. Differential Revision: D58949662 |
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Jun 24, 2024
…onses (facebook#45136) Summary: Pull Request resolved: facebook#45136 Adds a URL path (`/open-debugger?some-query-params`) for each of the debug targets listed by `/list/json` that may be used to trigger opening the debugger frontend via a POST to the inspector server. Changelog: [General][Added] Inspector: Add reactNative.openDebuggerPath to /json/list responses Differential Revision: D58949662
e83376b
to
ffc71c5
Compare
…n-debugger Summary: Previously, if the `/open-debugger` endpoint was provided with both `device` and `appId` query params, we would: - Try to find a target with a matching `device` (note that these logical "devices" are unique per-app) - if found, use it. Otherwise, - Try to find a target with a matching `appId` - if found, use that. This could go "wrong" in two ways: - If a `device` is given with a spurious `appId`, we'd open to a target with an `appId` differing from the one specified. - If the `device` has gone away but there is a different target with the same app, we'd use that as a fallback (right app, wrong device). This applies the filters more strictly so that if both are given, both must match. Changelog: [General][Changed]: Inspector: Enforce device and appId filters if both are given to /open-debugger Differential Revision: D58951952
…page) Differential Revision: D58950622
…acebook#45136) Summary: Pull Request resolved: facebook#45136 Adds a URL path (`/open-debugger?some-query-params`) for each of the debug targets listed by `/list/json` that may be used to trigger opening the debugger frontend via a POST to the inspector server. Changelog: [General][Added] Inspector: Add reactNative.openDebuggerPath to /json/list responses Differential Revision: D58949662
This pull request was exported from Phabricator. Differential Revision: D58949662 |
ffc71c5
to
15041b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a URL path (
/open-debugger?some-query-params
) for each of the debug targets listed by/list/json
that may be used to trigger opening the debugger frontend via a POST to the inspector server.Changelog:
[General][Added] Inspector: Add reactNative.openDebuggerPath to /json/list responses
Differential Revision: D58949662