Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary dispatch to main thread #45344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sammy-SC
Copy link
Contributor

@sammy-SC sammy-SC commented Jul 9, 2024

Summary:
changelog: [internal]

the module already requires a main queue setup. Additional dispatch to the main queue is unnecessary.

Reviewed By: cipolleschi

Differential Revision: D59518378

sammy-SC added 2 commits July 9, 2024 03:14
Summary:
changelog: [internal]

the module already requires a main queue setup. Additional dispatch to the main queue is unnecessary.

Reviewed By: cipolleschi

Differential Revision: D59518378
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59518378

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,300,842 +16,703
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,497,579 +16,414
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 12b64b7
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants