Upgrade glob@7 to glob@10 to resolve deprecation warnings
#48875
+168
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Looks like just Flow errors. Will import and resolve. |
|
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Will see if I have time to test this today (need to secure a Windows device from around the office). |
|
Hey @huntie! I just got back from my Lunar new year tour. If there is any way I can help test the Glob changes on Windows, lmk. I literally have 2 desktops ready to go for that. |
robhogan
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 26, 2025
Summary: This is a long overdue follow-up from facebook/react-native#46724, and upgrades the deprecated `glob@7` to `glob@10`. When creating any React Native project today, you are greeted by a wall of deprecation warnings when installing with `npm` -- with the most frequent offender being `[email protected]`. This hurts UX and diminishes developers' trust, even before starting their project. <img width="1005" alt="image" src="https://github.com/user-attachments/assets/a5661470-98df-4f3f-8be2-7b0baa9711b6" /> Unfortunately, no [flow types are available for `glob@9+`](https://github.com/flow-typed/flow-typed/tree/main/definitions/npm). I've tried creating a flow definition, but it turns out that the `glob@10` types use `path-scurry@^1.11.1`, `minimatch@^9.0.4`, and `minipass@^7.1.2` -- all without flow type definitions. Writing the flow definitions for glob@9+ is non-trivial work, I'd be happy to help but I can't fix that on my own. > [!IMPORTANT] > `glob@11` has already been released, but it's only supporting Node 20+. I believe React Native still supports Node 18 until the EOL in April 2025, that's why I used `glob@10`. ## Changelog: [GENERAL] [CHANGED] - Upgrade from deprecated `glob@7` to supported `glob@10` <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [GENERAL] [CHANGED] - Upgrade from deprecated `glob@7` to supported `glob@10` For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests X-link: facebook/react-native#48875 Reviewed By: robhogan, cortinico Differential Revision: D69594539 Pulled By: huntie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a long overdue follow-up from #46724, and upgrades the deprecated
glob@7toglob@10.When creating any React Native project today, you are greeted by a wall of deprecation warnings when installing with
npm-- with the most frequent offender being[email protected]. This hurts UX and diminishes developers' trust, even before starting their project.Unfortunately, no flow types are available for
glob@9+. I've tried creating a flow definition, but it turns out that theglob@10types usepath-scurry@^1.11.1,minimatch@^9.0.4, andminipass@^7.1.2-- all without flow type definitions. Writing the flow definitions for glob@9+ is non-trivial work, I'd be happy to help but I can't fix that on my own.Important
glob@11has already been released, but it's only supporting Node 20+. I believe React Native still supports Node 18 until the EOL in April 2025, that's why I usedglob@10.Changelog:
[GENERAL] [CHANGED] - Upgrade from deprecated
glob@7to supportedglob@10Test Plan:
npm create expo@latest ./test-install-warningscd ./test-install-warningsrm -rf node_modulesnpm installnpm list [email protected]Most of the offending packages come from React Native packages, with some from
jest/jest-expo.