Do not consume component value on visitor failure #48985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68733518 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 28, 2025
Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
force-pushed
the
export-D68733518
branch
from
c4b9ca5 to
509ec31
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
|
This pull request was exported from Phabricator. Differential Revision: D68733518 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
force-pushed
the
export-D68733518
branch
from
509ec31 to
a1098a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68733518 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
force-pushed
the
export-D68733518
branch
from
a1098a7 to
d9db28f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68733518 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
force-pushed
the
export-D68733518
branch
from
d9db28f to
ea73a08
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68733518 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
Summary: tsia Also added a quick helper to CSSColor used later. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68741768
Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
force-pushed
the
export-D68733518
branch
from
ea73a08 to
51816ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68733518 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Differential Revision: D68733518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow).
Changelog: [internal]
Differential Revision: D68733518