New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSSCommaSeparatedValue #48987

Closed

NickGerleman wants to merge 3 commits into facebook:main from NickGerleman:export-D68738165

Contributor

NickGerleman commented Jan 28, 2025

Summary:
Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. CSSCommaSeparatedList<CSSShadow> will represent the syntax of <shadow># (ie the value produced by box-shadow).

Changelog: [internal]

Differential Revision: D68738165

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Jan 28, 2025

This pull request was exported from Phabricator. Differential Revision: D68738165

facebook-github-bot added the fb-exported label

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          CSSCommaSeparatedValue (facebook#48987)

a122b41

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from d3c91f3 to bec16da Compare

January 29, 2025 18:59

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          CSSCommaSeparatedList (facebook#48987)

bec16da

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

f412308

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

37caeaf

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

cdd7908

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          CSSCommaSeparatedList (facebook#48987)

367e044

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from bec16da to 367e044 Compare

January 29, 2025 20:05

Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from 367e044 to 9534555 Compare

January 29, 2025 20:06

Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from 9534555 to 566c292 Compare

January 29, 2025 20:09

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          CSSCommaSeparatedList (facebook#48987)

3e9cb6b

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from 566c292 to 3e9cb6b Compare

January 29, 2025 20:09

Contributor

facebook-github-bot commented Jan 29, 2025

This pull request was exported from Phabricator. Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

243067c

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          CSSCommaSeparatedList (facebook#48987)

abd5495

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from 3e9cb6b to abd5495 Compare

February 3, 2025 22:32

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

80d58a8

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

eb0e1e1

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

472b5ab

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from abd5495 to f7de4c2 Compare

February 3, 2025 22:32

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          CSSCommaSeparatedList (facebook#48987)

f7de4c2

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

Contributor

facebook-github-bot commented Feb 3, 2025

This pull request was exported from Phabricator. Differential Revision: D68738165

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          CSSCommaSeparatedList (facebook#48987)

9bb6ba7

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from f7de4c2 to 9bb6ba7 Compare

February 3, 2025 22:37

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

da7ffa1

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman added 3 commits

February 4, 2025 11:15


          [skip ci] Do not consume component value on visitor failure (facebook…

6879e09

…#48985)

Summary:

This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68733518


          [skip ci] CSSDataTypeParser consume() function (facebook#48986)

91e2001

Summary:

This adds a new `consume()` function to data type parsers which passes a raw parser. This can be used for types which are compounds of other data types, where we may want to accept more than the first token.

This will be used for shadow parsing, but also fixes a hypothetical future bug with ratios. E.g. `calc(foo) / calc(bar)` may be a valid ratio, not starting with a token. We instead just want to try to parse a number data type from the stream.

The form of parsing a preserved token + rest is removed, with the assumption that anything parsing more than a single token should use compound parsing.

Changelog: [Internal]

Reviewed By: lenaic

Differential Revision: D68735370


          CSSCommaSeparatedList (facebook#48987)

78bdbef

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

NickGerleman force-pushed the export-D68738165 branch from 9bb6ba7 to 78bdbef Compare

February 4, 2025 19:16

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          [skip ci] CSSCommaSeparatedList (facebook#48987)

c223f95

Summary:

Adds a data type parser for a variable number of values of a given single data type (at least 1).

E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).

Changelog: [internal]

Reviewed By: lenaic

Differential Revision: D68738165

Contributor

facebook-github-bot commented Feb 4, 2025

This pull request was exported from Phabricator. Differential Revision: D68738165

facebook-github-bot closed this in

f77fced

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Feb 4, 2025

This pull request has been merged in f77fced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner