Fix missing handling of "inset" CSS Keyword #48990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 28, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
force-pushed
the
export-D68743950
branch
from
f26a9ef to
7621538
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
force-pushed
the
export-D68743950
branch
from
7621538 to
017613f
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
NickGerleman
force-pushed
the
export-D68743950
branch
from
017613f to
0d760bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
NickGerleman
force-pushed
the
export-D68743950
branch
from
0d760bc to
c701974
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 29, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
force-pushed
the
export-D68743950
branch
from
c701974 to
a31bd20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 3, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
force-pushed
the
export-D68743950
branch
from
a31bd20 to
d2325f9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 3, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
force-pushed
the
export-D68743950
branch
from
d2325f9 to
c49bca9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 3, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 3, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 3, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
force-pushed
the
export-D68743950
branch
from
c49bca9 to
a9c7648
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 3, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
…#48985) Summary: This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow). Changelog: [internal] Reviewed By: lenaic Differential Revision: D68733518
Summary: This adds a new `consume()` function to data type parsers which passes a raw parser. This can be used for types which are compounds of other data types, where we may want to accept more than the first token. This will be used for shadow parsing, but also fixes a hypothetical future bug with ratios. E.g. `calc(foo) / calc(bar)` may be a valid ratio, not starting with a token. We instead just want to try to parse a number data type from the stream. The form of parsing a preserved token + rest is removed, with the assumption that anything parsing more than a single token should use compound parsing. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68735370
Summary: Adds a data type parser for a variable number of values of a given single data type (at least 1). E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow). Changelog: [internal] Reviewed By: lenaic Differential Revision: D68738165
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
NickGerleman
force-pushed
the
export-D68743950
branch
from
a9c7648 to
56339c1
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 4, 2025
Summary: tsia Changelog: [Internal] Reviewed By: joevilches Differential Revision: D68743950
|
This pull request was exported from Phabricator. Differential Revision: D68743950 |
|
This pull request has been merged in 1624cdb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
tsia
Changelog: [Internal]
Reviewed By: joevilches
Differential Revision: D68743950