Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate com.facebook.react.packagerconnection interfaces to Kotlin #49025

Conversation

mateoguzmana
Copy link
Contributor

Summary:

Migrate com.facebook.react.packagerconnection interfaces to Kotlin. Also, moving to org.mockito.kotlin instead of org.mockito.Mockito for JSPackagerClientTest to make it compatible with the migrated files.

Changelog:

[INTERNAL] - Migrate com.facebook.react.packagerconnection interfaces to Kotlin

Test Plan:

yarn test-android
yarn android

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 28, 2025
@tdn120
Copy link

tdn120 commented Jan 29, 2025

Looks good! We might need to have Responder accept nullables, but I'll import as-is and see how it looks.

@facebook-github-bot
Copy link
Contributor

@tdn120 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 31, 2025
@facebook-github-bot
Copy link
Contributor

@tdn120 merged this pull request in 491ede6.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mateoguzmana in 491ede6

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants