Migrate files in Libraries/Modal and Libraries/Network to use export syntax #49035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68827032 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 29, 2025
…syntax (facebook#49035) Summary: ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff - Migrates files in `Libraries/Modal/*.js` and `Libraries/Network/*.js` to use the `export` syntax. - Updates deep-imports of these files to use `.default` - Updates jest mocks - Updates the current iteration of API snapshots (intended). Changelog: [General][Breaking] - Deep imports to modules inside `Libraries/Modal` and `Libraries/Network` with `require` syntax may need to be appended with '.default'. Differential Revision: D68827032
iwoplaza
force-pushed
the
export-D68827032
branch
from
a761119 to
b9d970c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68827032 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68827032 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 29, 2025
…syntax (facebook#49035) Summary: Pull Request resolved: facebook#49035 ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff - Migrates files in `Libraries/Modal/*.js` and `Libraries/Network/*.js` to use the `export` syntax. - Updates deep-imports of these files to use `.default` - Updates jest mocks - Updates the current iteration of API snapshots (intended). Changelog: [General][Breaking] - Deep imports to modules inside `Libraries/Modal` and `Libraries/Network` with `require` syntax may need to be appended with '.default'. Differential Revision: D68827032
iwoplaza
force-pushed
the
export-D68827032
branch
from
b9d970c to
fa9c965
Compare
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 30, 2025
…syntax (facebook#49035) Summary: ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff - Migrates files in `Libraries/Modal/*.js` and `Libraries/Network/*.js` to use the `export` syntax. - Updates deep-imports of these files to use `.default` - Updates jest mocks - Updates the current iteration of API snapshots (intended). Changelog: [General][Breaking] - Deep imports to modules inside `Libraries/Modal` and `Libraries/Network` with `require` syntax may need to be appended with '.default'. Reviewed By: huntie Differential Revision: D68827032
iwoplaza
force-pushed
the
export-D68827032
branch
from
fa9c965 to
85941fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68827032 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 30, 2025
…syntax (facebook#49035) Summary: ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff - Migrates files in `Libraries/Modal/*.js` and `Libraries/Network/*.js` to use the `export` syntax. - Updates deep-imports of these files to use `.default` - Updates jest mocks - Updates the current iteration of API snapshots (intended). Changelog: [General][Breaking] - Deep imports to modules inside `Libraries/Modal` and `Libraries/Network` with `require` syntax may need to be appended with '.default'. Reviewed By: huntie Differential Revision: D68827032
iwoplaza
force-pushed
the
export-D68827032
branch
from
85941fc to
38eddcb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68827032 |
…syntax (facebook#49035) Summary: ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff - Migrates files in `Libraries/Modal/*.js` and `Libraries/Network/*.js` to use the `export` syntax. - Updates deep-imports of these files to use `.default` - Updates jest mocks - Updates the current iteration of API snapshots (intended). Changelog: [General][Breaking] - Deep imports to modules inside `Libraries/Modal` and `Libraries/Network` with `require` syntax may need to be appended with '.default'. Reviewed By: huntie Differential Revision: D68827032
iwoplaza
force-pushed
the
export-D68827032
branch
from
38eddcb to
3d6d1bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68827032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Modernising the RN codebase to allow for modern Flow tooling to process it.
This diff
Libraries/Modal/*.jsandLibraries/Network/*.jsto use theexportsyntax..defaultChangelog:
[General][Breaking] - Deep imports to modules inside
Libraries/ModalandLibraries/Networkwithrequiresyntax may need to be appended with '.default'.Differential Revision: D68827032