Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android tooltipText prop #49044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iliapnmrv
Copy link

Summary:

I'd like to add an Android tooltipTextAndroid prop (using View.setTooltipText) to <View> in RN.
This should allow users to specify text that appears on long-press.

Currently, if I pass tooltipTextAndroid to <View>, the prop is received by the native code (BaseViewManager.java), but the tooltip does not appear on long press.

I tried both ViewCompat.setTooltipText(view, tooltipText) and view.setTag(...) approaches

I’m opening this PR early to gather feedback on what might be missing to make the tooltip appear.

Changelog:

[Android] [Added] - Add View tooltipTextAndroid prop

Test Plan:

I've added example component to View section. It should show tooltip on long-press but it doesn't for now

@facebook-github-bot
Copy link
Contributor

Hi @iliapnmrv!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants