-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transform that strips private properties in build types script #49060
Conversation
This pull request was exported from Phabricator. Differential Revision: D68892853 |
…acebook#49060) Summary: We want to hide private properties from JS public API interface. The stripPrivateProperties transform removes all private nodes of type ObjectTypeProperty, Property, PropertyDefinition and MethodDefinition. There is also a change in transforms reducer that incorporates `print` function from hermes-transform which modifies the code base on the transformed ast (transformed.mutatedCode seems to be a code before the transform operation). ## Changelog: [Internal] - Added transform that strips private properties in build-types script Differential Revision: D68892853
55b3c56
to
9b2e46a
Compare
This pull request was exported from Phabricator. Differential Revision: D68892853 |
…acebook#49060) Summary: We want to hide private properties from JS public API interface. The stripPrivateProperties transform removes all private nodes of type ObjectTypeProperty, Property, PropertyDefinition and MethodDefinition. There is also a change in transforms reducer that incorporates `print` function from hermes-transform which modifies the code base on the transformed ast (transformed.mutatedCode seems to be a code before the transform operation). ## Changelog: [Internal] - Added transform that strips private properties in build-types script Reviewed By: huntie Differential Revision: D68892853
9b2e46a
to
add24e0
Compare
This pull request was exported from Phabricator. Differential Revision: D68892853 |
…acebook#49060) Summary: We want to hide private properties from JS public API interface. The stripPrivateProperties transform removes all private nodes of type ObjectTypeProperty, Property, PropertyDefinition and MethodDefinition. There is also a change in transforms reducer that incorporates `print` function from hermes-transform which modifies the code base on the transformed ast (transformed.mutatedCode seems to be a code before the transform operation). ## Changelog: [Internal] - Added transform that strips private properties in build-types script Reviewed By: huntie Differential Revision: D68892853
add24e0
to
1520738
Compare
This pull request was exported from Phabricator. Differential Revision: D68892853 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D68892853 |
This pull request was successfully merged by @coado in 4ccb2f2 When will my fix make it into a release? | How to file a pick request? |
Summary:
Changelog:
[Internal] - Added transform that strips private properties in build-types script
Differential Revision: D68892853