Bugfix/rootview leak

[zhaozihaoandroid]

Summary:

when we use react-native in our hybrid app, we make more then one ReactInstanceManager instance and every RN page is in new Activity Container. if we reuse the ReactInstanceManager in same business, when Activity Container is destroy, we found the ReactRootView is not removed, so it is leaked. the key point is previous page is not use this ReactInstanceManager instance.

Changelog:

[ANDROID][FIXED] - Fix ReactRootView Memory Leak。

Test Plan:

follow the steps:

1. write a log in RemoveRootViewOperation.execute() method

Log.i("RN", "RemoveRootViewOperation removeRootView");

2. install RNTester app
3. open RN page
4. close RN page
5. see the log

Expect： print RemoveRootViewOperation removeRootView.

[facebook-github-bot]

Hi @zhaozihaoandroid!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[arushikesarwani94]

cc: @mlord93 who did a pretty similar fix recently internally.

[zhaozihaoandroid]

cc: @mlord93 who did a pretty similar fix recently internally.

i see his recently pr is not fix this question @arushikesarwani94 .
@mlord93 can you make sure this question is did fix or not?