fix: make requestIdleCallback handle type a number
#50012
+22
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@robik we should have a Fantom test reproducing the issue and validating the fix. Conceptually, the current solution should work correctly. The fact that the handle is an opaque object vs. a number should have nothing to do with the linked issue. |
|
I added a placeholder testing some of the initial assumptions in: This introduces some complexity that, unless it fixes an actual bug, I'm not sure we should merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR changes the return value of
requestIdleCallbackand parameter type ofcancelIdleCallbackfrom opaque object with NativeState into number to further match WebAPI.Fixes #49684
Changelog:
[GENERAL] [FIXED] - Fixed
requestIdleCallbackhandle typeTest Plan: