-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix fetch of content scheme urls failing on Android #50122
base: main
Are you sure you want to change the base?
Conversation
PR created by splitting #48766 into two. |
Could you add or link a test-case to RNTester that shows what's broken here, and how this fixes it? |
...t-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.java
Outdated
Show resolved
Hide resolved
@javache I got RNTester built and running. I wasn't able to find an existing test case that provides tests for Blob / networking. Ideally to add a test case i would need to use a third-party library to get a valid url for a Video/Photo on the Android device's gallery. It would be inappropriate to add a library like '@react-native-camera-roll/camera-roll' to the RNTester package.json. Thought or advise on how to proceed ? As noted in the issue #48762 , to show whats broken use the Reproducer: Steps to reproduce:
|
Adding external libs to RNTester is something we tend to avoid as it makes our install time slower + there is some integration costs as RNTester lives inside our monorepo. So we'll have to make sure that all the deps imported by Perhaps we can have a really simple module to pick an image. For example on Android we can use an Intent with |
2e72045
to
8c95dfa
Compare
@javache @cortinico ![]() WITHOUT FIX: #48762 |
1f85400
to
f815598
Compare
f815598
to
c2cde57
Compare
Summary:
This PR fixes #48762
Changelog:
[ANDROID] [FIXED] - fix fetch of content scheme uris failing on Android.
Test Plan:
Used the App here to test Android Blob creation. https://github.com/giantslogik/blob-large-file-fetch.
EDIT: Added tester to RNTester