fix globals types #50278
Open
fix globals types #50278
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently some exported types use const keywords. But this doesn't look right as explained in TypeScript 3.4 changelog. > Note that global variables declared with let and const don’t show up on globalThis. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#type-checking-for-globalthis This means with current const declaration, this defined types are not accessible, which defeat the purpose. This PR should fix this problem (currently works for me using patch-package).
facebook-github-bot
added
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I am sharing code with the web using Next.js. Turbopack doesn't allow easy injection (yet?) for
__DEV__that's why I detected this issue when trying to inject this way:This code is currently throwing this error (with ts 5.8):
Currently some exported types use
constkeywords. But this doesn't look right as explained in TypeScript 3.4 changelog.https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#type-checking-for-globalthis
This means with current
constdeclaration, this defined types are not accessible, which defeat the purpose.Changelog:
[GENERAL] [FIXED] - globalThis now properly expose global vars
Test Plan:
This PR should fix this problem (currently works for me using patch-package).
Before this change
After this change