-
Notifications
You must be signed in to change notification settings - Fork 24.6k
Migrated file ReactStylesDiffMap to kotlin #50616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrated file ReactStylesDiffMap to kotlin #50616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! it looks generally good, some very small things to check
...s/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.kt
Outdated
Show resolved
Hide resolved
...s/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.kt
Outdated
Show resolved
Hide resolved
...s/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.kt
Outdated
Show resolved
Hide resolved
...s/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.kt
Outdated
Show resolved
Hide resolved
...s/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for the internal reviewer: This class has some OSS usages, so removing mBackingMap
hungarian notation would break OSS, probably that has to be suppressed if the linter fails
Oh really? What are those @mateoguzmana ? |
But, I may be misinforming by saying that |
I think the field itself is not used other than in one occurrence: |
@mateoguzmana given the last GH search, I think we can actually rename the field and make it internal/private |
Interesting, thanks for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing before it can be imported
...s/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStylesDiffMap.kt
Outdated
Show resolved
Hide resolved
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
This PR aims to migrate ReactStylesDiffMap from Java to kotlin as part of #50513
Changelog:
[ANDROID][CHANGED]Migrate ReactStylesDiffMap to Kotlin
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
Test Plan:
Tested on RN tester with both new and old arch