Skip to content

[RN][iOS] Do not generate ReactCodegen.podspec for libraries #50646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Apr 11, 2025

Summary:

While we were refactoring the generation of the podspec, we made a mistake and we started generating the ReactCodegen.podspec for both libraries and apps.

This must be generated only for apps.

Changelog:

[iOS][Fixed] - Generate ReactCodegen.podspec only for apps.

Test Plan:

GHA

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 11, 2025
@cipolleschi cipolleschi changed the base branch from main to 0.79-stable April 11, 2025 10:10
@cipolleschi cipolleschi marked this pull request as ready for review April 11, 2025 10:10
@fabriziocucci fabriziocucci merged commit f3c2804 into 0.79-stable Apr 14, 2025
6 of 7 checks passed
@fabriziocucci fabriziocucci deleted the cipolleschi/fix-reactcodegen-podspec-generation branch April 14, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants