Skip to content

[RN][Codegen] Do not generate Apple specific file for Android #50655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Apr 11, 2025

Summary:

We realized that when calling

npx react-native-community/cli codegen --path . --platform all --outputPath /tmp/codegen
We were generating in the android folder some files that are Apple-specific.

With this change, we should stop generating the Apple specific files in Android.

Changelog:

[General][Fixed] - Do not generate Apple specific files for Android

Test Plan:

Before After
Screenshot_2025-04-11_at_13 30 09 Screenshot 2025-04-11 at 13 44 16

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@cipolleschi cipolleschi changed the base branch from main to 0.79-stable April 11, 2025 12:52
@cipolleschi cipolleschi marked this pull request as ready for review April 11, 2025 12:54
@fabriziocucci fabriziocucci merged commit b2bacc4 into 0.79-stable Apr 14, 2025
6 of 8 checks passed
@fabriziocucci fabriziocucci deleted the cipolleschi/do-not-gen-ios-code-for-android branch April 14, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants