Convert to Kotlin - ReactTextInputManager #50656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff converts another class to Kotlin - ReactTextInputShadowNode Changelog: [Internal] [Changed] - ReactTextInputShadowNode to Kotlin Differential Revision: D72854819
Summary: This diff makes the following file internal - ReactTextInputShadowNode as part of our ongoing effort of reducing the API surface. There is only one usage in OSS: `react-native-aztec`. The library is abandoned with little weekly download so we should be good marking this as internal. Changelog: [Internal] [Changed] - ReactTextInputShadowNode is now internal. Differential Revision: D72854896
Summary: The ReactTextInputManager file is huge and really hard to migrate to Kotlin. Here I'm extracting 4 private inner classes to separate files and converting them to Kotlin. This will make reviewing the Kotlin migration of ReactTextInputManager a bit easier. Changelog: [Internal] [Changed] - Differential Revision: D72858396
Summary: This is going to convert to Kotlin one of the biggest class we have: ReactTextInputManager As this class is quite big, I suspect there will be breakages. https://github.com/search?type=code&q=%22%3A+ReactTextInputManager%22 I will investigate further and adjust the class as necessary. Changelog: [Android] [Breaking] - ReactTextInputManager is now in Kotlin Differential Revision: D72859925
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72859925 |
|
This pull request has been merged in ab47834. |
|
This pull request was successfully merged by @cortinico in ab47834 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is going to convert to Kotlin one of the biggest class we have: ReactTextInputManager
As this class is quite big, I suspect there will be breakages.
https://github.com/search?type=code&q=%22%3A+ReactTextInputManager%22
I will investigate further and adjust the class as necessary.
Changelog:
[Android] [Breaking] - ReactTextInputManager is now in Kotlin
Differential Revision: D72859925