Skip to content

Remove obsolete @TargetApi annotations for Lollipop (API 21) #50686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mateoguzmana
Copy link
Collaborator

@mateoguzmana mateoguzmana commented Apr 13, 2025

Summary:

Static code analysis detected obsolete SDK version checks.

Since the minimum supported SDK version is API 24, these checks for API 21 are no longer necessary and can be safely removed.

Changelog:

[INTERNAL] - Remove obsolete @TargetApi annotations for LOLLIPOP (API 21)

Test Plan:

yarn test-android
yarn android

CI should be green.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 13, 2025
@mateoguzmana mateoguzmana changed the title Remove obsolete @TargetApi annotations for LOLLIPOP Remove obsolete @TargetApi annotations for LOLLIPOP (API 21) Apr 13, 2025
@mateoguzmana mateoguzmana changed the title Remove obsolete @TargetApi annotations for LOLLIPOP (API 21) Remove obsolete @TargetApi annotations for LOLLIPOP (API 21) Apr 13, 2025
@mateoguzmana mateoguzmana marked this pull request as ready for review April 13, 2025 10:39
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 13, 2025
@mateoguzmana mateoguzmana changed the title Remove obsolete @TargetApi annotations for LOLLIPOP (API 21) Remove obsolete @TargetApi annotations for Lollipop (API 21) Apr 13, 2025
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 14, 2025
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in 6f2357a.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mateoguzmana in 6f2357a

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants