Skip to content

chore(android-new-arch): reproduce modal layout issues #50704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(android-new-arch): reproduce modal layout issues #50704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 132 additions & 9 deletions packages/rn-tester/js/examples/Playground/RNTesterPlayground.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,157 @@
*
* @flow strict-local
* @format
* @oncall react_native
*/

import type {RNTesterModuleExample} from '../../types/RNTesterTypes';

import RNTesterText from '../../components/RNTesterText';
import * as React from 'react';
import {StyleSheet, View} from 'react-native';
import {useState} from 'react';
import {Modal, Pressable, StyleSheet, Text, View} from 'react-native';

function causeJSThreadBlocking() {
const intervalId = setInterval(() => {
const start = Date.now();
while (Date.now() - start < 20) {
// Blocking operation
Math.random() * Math.random();
}
}, 16);
setTimeout(() => {
clearInterval(intervalId);
}, 10000);
}

function ModalInSequence(): React.Node {
const [firstModalVisible, setFirstModalVisible] = useState(false);
const [secondModalVisible, setSecondModalVisible] = useState(false);

const showSecondHideFirst = () => {
setFirstModalVisible(false);
setSecondModalVisible(true);
};

function Playground() {
return (
<View style={styles.container}>
<RNTesterText>
Edit "RNTesterPlayground.js" to change this file
</RNTesterText>
<Modal
key="first"
animationType="slide"
transparent={true}
visible={firstModalVisible}
onRequestClose={() => setFirstModalVisible(false)}>
<View
onLayout={e => {
causeJSThreadBlocking();
console.log('modal first', e.nativeEvent.layout);
}}
style={[styles.centeredView, styles.modalBackdrop]}>
<View style={styles.modalView}>
<Text style={styles.modalText}>This is the first modal</Text>
<Pressable
style={[styles.button, styles.buttonClose]}
onPress={async () => {
// await new Promise(resolve => setTimeout(resolve, 100));
setFirstModalVisible(false);
}}>
<Text style={styles.textStyle}>Close Modal</Text>
</Pressable>
<Pressable
style={[styles.button, styles.buttonOpen]}
onPress={showSecondHideFirst}>
<Text style={styles.textStyle}>Show Second Modal</Text>
</Pressable>
</View>
</View>
</Modal>

<Modal
key="second"
animationType="slide"
transparent={true}
visible={secondModalVisible}
onRequestClose={() => setSecondModalVisible(false)}>
<View
onLayout={e => {
console.log('modal second', e.nativeEvent.layout);
}}
style={[styles.centeredView, styles.modalBackdrop]}>
<View style={styles.modalView}>
<Text style={styles.modalText}>This is the second modal</Text>
<Pressable
style={[styles.button, styles.buttonClose]}
onPress={() => setSecondModalVisible(false)}>
<Text style={styles.textStyle}>Close Modal</Text>
</Pressable>
</View>
</View>
</Modal>

<Pressable
style={[styles.button, styles.buttonOpen]}
onPress={() => setFirstModalVisible(true)}>
<Text style={styles.textStyle}>Show First Modal</Text>
</Pressable>
</View>
);
}

const styles = StyleSheet.create({
container: {
display: 'flex',
alignItems: 'center',
paddingVertical: 30,
},
centeredView: {
flex: 1,
justifyContent: 'center',
alignItems: 'center',
},
modalBackdrop: {
backgroundColor: 'rgba(0, 0, 0, 0.5)',
},
modalView: {
backgroundColor: 'white',
margin: 20,
borderRadius: 20,
padding: 35,
alignItems: 'center',
shadowColor: '#000',
shadowOffset: {
width: 0,
height: 2,
},
shadowOpacity: 0.25,
shadowRadius: 4,
elevation: 5,
},
modalText: {
marginBottom: 15,
textAlign: 'center',
},
button: {
borderRadius: 20,
padding: 10,
marginVertical: 10,
elevation: 2,
minWidth: 150,
},
buttonOpen: {
backgroundColor: '#F194FF',
},
buttonClose: {
backgroundColor: '#2196F3',
},
textStyle: {
color: 'white',
fontWeight: 'bold',
textAlign: 'center',
},
});


export default ({
title: 'Playground',
name: 'playground',
description: 'Test out new features and ideas.',
render: (): React.Node => <Playground />,
render: (): React.Node => <ModalInSequence />,
}: RNTesterModuleExample);

Loading