-
Notifications
You must be signed in to change notification settings - Fork 24.7k
refactor: migrated file LazyReactPackage to Kotlin #51085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrated file LazyReactPackage to Kotlin #51085
Conversation
Hi @Xintre! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
7c90936
to
e22458b
Compare
@mateoguzmana the PR is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migrating this! some small remarks.
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
fce91a0
to
468ecbb
Compare
468ecbb
to
84488e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks generally good. Leaving some comments to make it better
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.kt
Outdated
Show resolved
Hide resolved
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cortinico merged this pull request in b4ae5c1. |
This pull request was successfully merged by @Xintre in b4ae5c1 When will my fix make it into a release? | How to file a pick request? |
Summary:
This PR migrates LazyReactPackage to Kotlin as requested in #50513.
Changelog:
[ANDROID] [CHANGED] - Migrate com.facebook.react.LazyReactPackage to Kotlin.
Test Plan:
BaseReactPackage
withLazyReactPackage
inRNTesterApplication.kt