Refactor out unused bundleType from BundleOptions
#51094
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Metro `bundleType` is only used by Metro's reporter upon receipt of a request to Metro server, and is unnecessarily part of `BundleOptions` as passed to serialisers. Within the server, it's redundant because we've already inspected the `pathname` extension of `.bundle`, etc, before deciding which request processor to use - so we can simply make it part of creating the request processor, instead of passing the same string to every call to the processor. This diff removes `bundleType` from the `BundleOptions` type while retaining it in the return type of `parseOptionsFromUrl` (a public API) for now. Callers may continue to pass it - it'll be unused as it always has been - so this is non-breaking ## React Native Remove `bundleType`, unused in Metro <=0.82.2 and invalid in Metro 0.82.3. The Flow suppression may be removed once 0.82.3 is published, but is temporarily required because the Flow types are different in `main` (Meta-internal CI) vs latest published (OSS CI). Changelog: [Internal] Differential Revision: D74150833
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74150833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Metro
bundleTypeis only used by Metro's reporter upon receipt of a request to Metro server, and is unnecessarily part ofBundleOptionsas passed to serialisers.Within the server, it's redundant because we've already inspected the
pathnameextension of.bundle, etc, before deciding which request processor to use - so we can simply make it part of creating the request processor, instead of passing the same string to every call to the processor.This diff removes
bundleTypefrom theBundleOptionstype while retaining it in the return type ofparseOptionsFromUrl(a public API) for now.Callers may continue to pass it - it'll be unused as it always has been - so this is non-breaking
React Native
Remove
bundleType, unused in Metro <=0.82.2 and invalid in Metro 0.82.3. The Flow suppression may be removed once 0.82.3 is published, but is temporarily required because the Flow types are different inmain(Meta-internal CI) vs latest published (OSS CI).Changelog: [Internal]
Differential Revision: D74150833