Skip to content

Fix: Deprecation error in release builds for Catalyst #51137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Deprecation error in release builds for Catalyst #51137

wants to merge 1 commit into from

Conversation

tanaytanay
Copy link

@tanaytanay tanaytanay commented May 6, 2025 •
edited
Loading

Summary:

This PR fixes a build error when compiling a release build for Mac Catalyst.

The issue was caused by incorrect or unsafe handling of Objective-C types (BOOL vs NSNumber) and a deprecated method being called unconditionally.

To resolve this, I:

  • Wrapped the deprecated method usage inside a #if DEBUG block to avoid it in release builds.
  • Explicitly cast NSNumber to BOOL before passing to the delegate method, which is necessary in stricter release builds.
  • Added a fallback error reporting path using ExceptionsManager with a runtime null check.

Changelog:

[iOS] [Fixed] - Fix Mac Catalyst release build error caused by unguarded use of deprecated selector and BOOL casting

Test Plan:

  • Successfully built the project in release mode for Mac Catalyst.
  • Verified error handling behavior in debug builds remains unchanged.
  • Confirmed ExceptionsManager is used correctly when the delegate method is unavailable.
  • Added #pragma and #if DEBUG to ensure deprecated code is isolated to debug builds.
  • Logged fallback path to confirm it triggers correctly when needed.

@facebook-github-bot
Copy link
Contributor

Hi @tanaytanay!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 6, 2025
@javache
Copy link
Member

javache commented May 7, 2025

Calling the deprecated method only in DEBUG, is not the right way to deprecate this, and will cause inconsistent behaviour between debug and release builds.

Suppressing the diagnostic is reasonable, but please reduce the scope of the changes here.

philIip
philIip reviewed May 7, 2025
View reviewed changes
packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm Outdated
errorData[@"stack"] = stack;
errorData[@"id"] = @(error.id);
errorData[@"isFatal"] = @(error.isFatal);
NSMutableDictionary<NSString *, id> *errorData = [NSMutableDictionary new];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also fix the indentation here so we can get the actual changelog

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done!

@tanaytanay tanaytanay force-pushed the fix-catalyst-release branch from bcee5ed to e3bdac7 Compare May 12, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philIip philIip philIip left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanaytanay @facebook-github-bot @javache @philIip