Fabric: Export shadow node family to javascript #51146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D73874822
Differential Revision: D74095745
Differential Revision: D74095747
Differential Revision: D74095746
Summary: The dev bundle has leaks. Differential Revision: D74095744
Summary: Currently, `IntersectionObserver#observe` retains a reference to the `ShadowNode` of the view that is supplied as an argument, which is used to compute intersection whenever a shadow tree is committed. However, the `shadowNode` includes all of child nodes and state at the time that `IntersectionObserver#observe` is called. This means that an active `IntersectionObserverEntry` will retain references to memory that would otherwise be deallocated (e.g. if children of the observed view are unmounted after `IntersectionObserver#observe` is called). This diff refactors `IntersectionObserver` to instead retain a reference to the `ShadowNodeFamily`, which does not retain references to child nodes and still eanbles `IntersectionObserver` to compute intersections. Changelog: [General][Changed] - Fixed `IntersectionObserver#observe` to avoid retaining memory for unmounted child nodes of observed views. Differential Revision: D74130479
Summary: IntersectionObserverManager now uses families to manage IntersectionObservers. This diff just migrates its apis to family too. Changelog: [Internal] Differential Revision: D74263375 Reviewed By: yungsters
Summary: InteresectionObserver caches shadow nodes in javascript. This is hazardous: caching shadow nodes could lead to memory leaks. Therefore, this diff exports shadow node families to javascript via fabric ui manager. This way, we don't have to cache the shadow nodes in js. Changelog: [ Reviewed By: yungsters Differential Revision: D74262805
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74262805 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
May 6, 2025
…1146) Summary: InteresectionObserver caches shadow nodes in javascript. This is hazardous: caching shadow nodes could lead to memory leaks. Therefore, this diff exports shadow node families to javascript via fabric ui manager. This way, we don't have to cache the shadow nodes in js. Changelog: [ Reviewed By: yungsters Differential Revision: D74262805
|
Closed internally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
InteresectionObserver caches shadow nodes in javascript.
This is hazardous: caching shadow nodes could lead to memory leaks.
Therefore, this diff exports shadow node families to javascript via fabric ui manager.
This way, we don't have to cache the shadow nodes in js.
Changelog: [
Reviewed By: yungsters
Differential Revision: D74262805