[iOS][prebuild] fixed build type when downloading hermes artifacts #51283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the prebuild script: `node scripts/ios-prebuild.js` The script will now try to resolve and download a prebuilt version of hermes: 1. Hermes artifacts will be extracted to the `./build/artifacts/hermes` folder to ensure that Package.swift can find a version to link against. 2. The script checks the environment variable `HERMES_ENGINE_TARBALL_PATH` and tries do expand the tarball into the artifacts folder from 1 3. If not found, the script reads the hermes version from either the hidden environment-variable `HERMES_VERSION` and tries to download a release-tarball or a nightly tarball for this version. If the version does not exist, the script will fail. Added some extra logging features to the script.
Co-authored-by: Riccardo Cipolleschi <[email protected]>
- Added `prebuildLog` function to harmonize output - Reduced output from creating headers
Hermes build-type was hardcoded to 'release' in the previous version of the prebuild scripts. This commit fixes this so that we can provide a build-type for hermes when downloading prebuilt tarballs. - Cleaned up parameters in hermes.js - Updated with buildType parameter when suitable - Fixed some function names - Updated version file so that it contains build type - Removed version file when using a local tarball
facebook-github-bot
added
the
CLA Signed
Fixed some failing flow declarations
facebook-github-bot
added
the
Shared with Meta
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Hermes build-type was hardcoded to 'release' in the previous version of the prebuild scripts.
This commit fixes this so that we can provide a build-type for hermes when downloading prebuilt tarballs.
Changelog:
[IOS] [FIXED] - Fixed resolving build type when downloading hermes artifacts
Test Plan:
No test-plan yet