Fix generated types base on __typetests__ #51317
Open
+222
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported - changing `overlayColor` type to `ColorValue` to align with manual types - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type. - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter` - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported. - removing `Animated.legacyRef` type test - not included in new types - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors. Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` , - bumping `definitelytyped/dtslint` to 0.0.178 version which removes `testNoTsIgnore` check [here](microsoft/DefinitelyTyped-tools@0e0838a) Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` , - bumping `definitelytyped/dtslint` to 0.0.178 version which removes `testNoTsIgnore` check [here](microsoft/DefinitelyTyped-tools@0e0838a) Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: Pull Request resolved: facebook#51317 This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` , - bumping `definitelytyped/dtslint` to 0.0.178 version which removes `testNoTsIgnore` check [here](microsoft/DefinitelyTyped-tools@0e0838a) Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` , - bumping `definitelytyped/dtslint` to 0.0.178 version which removes `testNoTsIgnore` check [here](microsoft/DefinitelyTyped-tools@0e0838a) Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
coado
added a commit
to coado/react-native
that referenced
this pull request
May 15, 2025
Summary: This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` , - bumping `definitelytyped/dtslint` to 0.0.178 version which removes `testNoTsIgnore` check [here](microsoft/DefinitelyTyped-tools@0e0838a) Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
Summary: Pull Request resolved: facebook#51317 This diff is a set of alignments/improvements in generated TS types. It includes: - extending `AppStateStatus` with `extension` and `unknown`, - exporting `AnimatedProps` under Animated namespace, - resolving issue with discriminated unions in `ProgressBarAndroidTypes`, - fixing `StyleSheet.create` type to accept only specified style properties, - extending `TextProps` with `AccessibilityProps`, - extending Fn `Args` generic with `$ReadOnlyArray` in `ErrorUtils`, - small `__typetests__` adjustments, - removing type test `styleDimensionValueValidAnimated` as `DimensionValue` no longer accepts `AnimatedNode` , - removing `styleDimensionValueInvalid` as `DimensionValue` accepts any string now - template literal types in Flow are not supported, - changing `overlayColor` type to `ColorValue` to align with manual types, - fixing `AnimatedPropsAllowlist` type which wasn't correct in TS because index signature type was different from style type, - using `DeviceEventEmitter` instead of `DeviceEventEmitterStatic` in type tests which is equivalent in both new and old types - `DeviceEventEmitterStatic` was only a type of `DeviceEventEmitter`, - removing type test for checking forwarded key type - doesn't work with new types and that shouldn't be supported, - removing `Animated.legacyRef` type test - not included in new types, - adding `DOMRect` from "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors, - exporting `SectionListData` , - bumping `definitelytyped/dtslint` to 0.0.178 version which removes `testNoTsIgnore` check [here](microsoft/DefinitelyTyped-tools@0e0838a) Changelog: [Internal] Reviewed By: huntie Differential Revision: D74246304
|
This pull request was exported from Phabricator. Differential Revision: D74246304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is a set of alignments/improvements in generated TS types. It includes:
AppStateStatuswithextensionandunknown,AnimatedPropsunder Animated namespace,ProgressBarAndroidTypes,StyleSheet.createtype to accept only specified style properties,TextPropswithAccessibilityProps,Argsgeneric with$ReadOnlyArrayinErrorUtils,__typetests__adjustments,styleDimensionValueValidAnimatedasDimensionValueno longer acceptsAnimatedNode,styleDimensionValueInvalidasDimensionValueaccepts any string now - template literal types in Flow are not supported,overlayColortype toColorValueto align with manual types,AnimatedPropsAllowlisttype which wasn't correct in TS because index signature type was different from style type,DeviceEventEmitterinstead ofDeviceEventEmitterStaticin type tests which is equivalent in both new and old types -DeviceEventEmitterStaticwas only a type ofDeviceEventEmitter,Animated.legacyReftype test - not included in new types,DOMRectfrom "dom" lib to globals.d.ts to not include "dom" lib in the tsconfig - tries to compare globals with lib.dom.d.ts and produces many errors,SectionListData,@definitelytyped/dtslintto0.0.178version which removestestNoTsIgnorecheck hereChangelog:
[Internal]
Reviewed By: huntie
Differential Revision: D74246304