Fix compose views crashing inside RN Modal component. #51319
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
What's the crash? Can you provide the stacktrace? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enables using ComposeView, in particular as used in expo-ui and other compose libraries, inside RN modals.
Without it, apps crash with a a client crash related to the ViewTreeLifecycleOwner.
With it, components inside expo-ui render correctly inside modals.
This change is applied inside RN Modal, instead of expo-ui internals, since we to set the appropriate fields on every new dialog mounted.
Relevant expo/expo issue: expo/expo#36816
Changelog:
[ANDROID][FIXED] – Fix compose views crashing inside RN Modal component.
Test Plan:
I tested a reproduction linked in the expo/expo issue – this change makes the app not crash.