Remove useEditTextStockAndroidBehavior and resolve old android blur issue #51338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Original commit changeset: 12dcaf0c9c35 Original Phabricator Diff: D74678847 Differential Revision: D74754164
Summary: Original commit changeset: 4682cf709aa2 Original Phabricator Diff: D73954790 Differential Revision: D74754010
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74760594 |
…ssue (facebook#51338) Summary: Pull Request resolved: facebook#51338 There was some problems removing this feature flag earlier in that, on older android versions, we would try to focus the top most text input whenever any other text input would try to blur. This was ultimately and issue with how Android implements `clearFocus`. To fix this, lets block the focusability of all views while we clear the focus, then re-enable. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D74760594
|
This pull request was exported from Phabricator. Differential Revision: D74760594 |
joevilches
force-pushed
the
export-D74760594
branch
from
acdcd41 to
1e6dec0
Compare
|
This pull request has been merged in d07b2a9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There was some problems removing this feature flag earlier in that, on older android versions, we would try to focus the top most text input whenever any other text input would try to blur. This was ultimately and issue with how Android implements
clearFocus. To fix this, lets block the focusability of all views while we clear the focus, then re-enable.Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D74760594