Make processingStartTime and processingEndTime optional #51390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74811439 |
Summary: Pull Request resolved: facebook#51254 # Changelog: [Internal] Defines single timestamp abstraction that will be used in C++ layer of React Native core: Key primitives include: - `HighResTimeStamp`: A class representing a specific point in time with high precision. - `HighResDuration`: A class representing a duration of time with high precision. Right now, all these just encapsulate `std::chrono::steady_clock` with no extra custom logic. We might revisit this in a future, once we decide to add support for [`Performance.timeOrigin`](https://developer.mozilla.org/en-US/docs/Web/API/Performance/timeOrigin). This diff also adds a `README.md` documentation file with a brief summary of the `react/timing` module. Differential Revision: D72796412
…facebook#51253) Summary: Pull Request resolved: facebook#51253 # Changelog: [Internal] Defines bridging template for `HighResTimeStamp` and `HighResTimeDuration`. When these values are passed to JavaScript over bridge, they will be converted to [`DOMHighResTimeStamp`](https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp). Also the other way around, when we list `HighResTimeStamp` or `HighResTimeDuration` as a type of TurboModule spec, it will expect number value from JavaScript. Differential Revision: D74506516
…acebook#51251) Summary: Pull Request resolved: facebook#51251 # Changelog: [Internal] Replaces `RuntimeSchedulerClock`, which was an alias for `std::chrono::steady_clock` with previously defined single timestamp abstraction. Differential Revision: D74246459 Reviewed By: rubennorte
…rt (facebook#51252) Summary: Pull Request resolved: facebook#51252 # Changelog: [Internal] Removes usage of `DOM_HIGH_RES_TIME_STAMP_UNSET` stub contstexpr. Instead, all events that were using it will now declare timestamps as optional. This is the pre-requisite before migrating these raw `double` values to `HighResTimeStamp`. Differential Revision: D74248998 Reviewed By: javache
Summary: Pull Request resolved: facebook#51390 # Changelong: [Internal] Ideally, these should not be optional, but these values are set at runtime. Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`. Reviewed By: rshest Differential Revision: D74811439
|
This pull request was exported from Phabricator. Differential Revision: D74811439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelong: [Internal]
Ideally, these should not be optional, but these values are set at runtime.
Assertions added to validate that these values are set before reporting to
PerformanceEntryReporter.Differential Revision: D74811439