-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Make processingStartTime and processingEndTime optional #51390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was exported from Phabricator. Differential Revision: D74811439 |
This pull request was exported from Phabricator. Differential Revision: D74811439 |
Summary: Pull Request resolved: facebook#51390 # Changelong: [Internal] Ideally, these should not be optional, but these values are set at runtime. Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`. Reviewed By: rshest Differential Revision: D74811439
Summary: # Changelong: [Internal] Ideally, these should not be optional, but these values are set at runtime. Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`. Reviewed By: rshest Differential Revision: D74811439
Summary: # Changelong: [Internal] Ideally, these should not be optional, but these values are set at runtime. Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`. Reviewed By: rshest Differential Revision: D74811439
Summary: Pull Request resolved: facebook#51390 # Changelong: [Internal] Ideally, these should not be optional, but these values are set at runtime. Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`. Reviewed By: rshest Differential Revision: D74811439
This pull request was exported from Phabricator. Differential Revision: D74811439 |
This pull request has been merged in efcc798. |
This pull request was successfully merged by @hoxyq in efcc798 When will my fix make it into a release? | How to file a pick request? |
Summary:
Changelong: [Internal]
Ideally, these should not be optional, but these values are set at runtime.
Assertions added to validate that these values are set before reporting to
PerformanceEntryReporter
.Differential Revision: D74811439