Skip to content

Make processingStartTime and processingEndTime optional #51390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented May 16, 2025

Summary:

Changelong: [Internal]

Ideally, these should not be optional, but these values are set at runtime.

Assertions added to validate that these values are set before reporting to PerformanceEntryReporter.

Differential Revision: D74811439

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 16, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74811439

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74811439

@hoxyq hoxyq force-pushed the export-D74811439 branch from 3eb03fc to f2f4621 Compare May 16, 2025 17:21
hoxyq added a commit to hoxyq/react-native that referenced this pull request May 16, 2025
Summary:
Pull Request resolved: facebook#51390

# Changelong: [Internal]

Ideally, these should not be optional, but these values are set at runtime.

Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`.

Reviewed By: rshest

Differential Revision: D74811439
@hoxyq hoxyq force-pushed the export-D74811439 branch from f2f4621 to 27c438e Compare May 19, 2025 13:46
hoxyq added a commit to hoxyq/react-native that referenced this pull request May 19, 2025
Summary:

# Changelong: [Internal]

Ideally, these should not be optional, but these values are set at runtime.

Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`.

Reviewed By: rshest

Differential Revision: D74811439
hoxyq added a commit to hoxyq/react-native that referenced this pull request May 19, 2025
Summary:

# Changelong: [Internal]

Ideally, these should not be optional, but these values are set at runtime.

Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`.

Reviewed By: rshest

Differential Revision: D74811439
Summary:
Pull Request resolved: facebook#51390

# Changelong: [Internal]

Ideally, these should not be optional, but these values are set at runtime.

Assertions added to validate that these values are set before reporting to `PerformanceEntryReporter`.

Reviewed By: rshest

Differential Revision: D74811439
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D74811439

@hoxyq hoxyq force-pushed the export-D74811439 branch from 27c438e to 414a47f Compare May 19, 2025 13:51
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 19, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in efcc798.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @hoxyq in efcc798

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants