Refactor the prebuild script to use fetch instead of curl #51398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74886699 |
Summary: When running the prebuild script: `node scripts/ios-prebuild.js` The script will now try to resolve and download a prebuilt version of hermes: 1. Hermes artifacts will be extracted to the `./build/artifacts/hermes` folder to ensure that Package.swift can find a version to link against. 2. The script checks the environment variable `HERMES_ENGINE_TARBALL_PATH` and tries do expand the tarball into the artifacts folder from 1 3. If not found, the script reads the hermes version from either the hidden environment-variable `HERMES_VERSION` and tries to download a release-tarball or a nightly tarball for this version. If the version does not exist, the script will fail. Also added some extra logging features to the script. bypass-github-export-checks ## Changelog: [IOS] [ADDED] - Added downloading of hermes artifacts when pre-building for iOS. Pull Request resolved: facebook#51216 Test Plan: 1. Delete the `packages/react-native/.build` folder 2. Run the build script (provide a valid HERMES_ENGINE_TARBALL_PATH or a valid Hermes version (or nightly version) 3. Verify that the script successfully exits 4. Build the Package.swift in Xcode and verify that it finds and links the relevant Hermes files, verifying is done by the build succeeding. Differential Revision: D74565936
…oad the correct commit data. Differential Revision: D74569484
Summary: Our Cocoapods config has a list of defines that are used mostly when setting up pods: - RCT_FABRIC_ENABLED - USE_HERMES - RCT_AGGREGATE_PRIVACY_FILES - RCT_NEW_ARCH_ENABLED - APP_PATH - REACT_NATIVE_PATH - RCT_SKIP_CODEGEN - SWIFT_ACTIVE_COMPILATION_CONDITIONS - USE_FRAMEWORKS - USE_THIRD_PARTY_JSC - HERMES_ENABLE_DEBUGGER - REACT_NATIVE_DEBUGGER_ENABLED - REACT_NATIVE_DEBUGGER_ENABLED_DEVONLY Out of these, only the following are used in objective-c/c code: - USE_HERMES - HERMES_ENABLE_DEBUGGER - REACT_NATIVE_DEBUGGER_ENABLED - REACT_NATIVE_DEBUGGER_ENABLED_DEVONLY This commit adds the required defines to the correct targets. ## Changelog: Pick one each for the category and type tags: [IOS] [FIXED] - fixed defines in package.swift Pull Request resolved: facebook#51284 Test Plan: No test-plan yet Differential Revision: D74872272 Reviewed By: cortinico Pulled By: cortinico
…oad the correct commit data. Differential Revision: D74882001
|
This pull request was exported from Phabricator. Differential Revision: D74886699 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 18, 2025
…1398) Summary: Pull Request resolved: facebook#51398 As a followup after the comment of D74565936 (https://www.internalfb.com/diff/D74565936?dst_version_fbid=727294986523938&transaction_fbid=1121452289999956), I refactored the code to use `fetch` instead of `curl`. ## Changelog: [Internal] - Refactor the code to use Fetch instead of curl Differential Revision: D74886699
cipolleschi
force-pushed
the
export-D74886699
branch
from
2e2d65e to
3b573df
Compare
…1398) Summary: Pull Request resolved: facebook#51398 As a followup after the comment of D74565936 (https://www.internalfb.com/diff/D74565936?dst_version_fbid=727294986523938&transaction_fbid=1121452289999956), I refactored the code to use `fetch` instead of `curl`. ## Changelog: [Internal] - Refactor the code to use Fetch instead of curl Differential Revision: D74886699
|
This pull request was exported from Phabricator. Differential Revision: D74886699 |
cipolleschi
force-pushed
the
export-D74886699
branch
from
3b573df to
1825d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As a followup after the comment of D74565936 (https://www.internalfb.com/diff/D74565936?dst_version_fbid=727294986523938&transaction_fbid=1121452289999956), I refactored the code to use
fetchinstead ofcurl.Changelog:
[Internal] - Refactor the code to use Fetch instead of curl
Differential Revision: D74886699