Fix accessibilityState serialization for props diffing of View component #51420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74910744 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
May 16, 2025
…ent (facebook#51420) Summary: The checked and unchecked state of the accessibility state property has to be serialized as `{ "checked": true }` and `{"checked": false}`. This diff updates the serialization of the `accessibilityState` prop for the prop diffing on the View component. This fixes the e2e test selectors for radio buttons. Changelog: [Internal] Differential Revision: D74910744
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
May 16, 2025
…ent (facebook#51420) Summary: The checked and unchecked state of the accessibility state property has to be serialized as `{ "checked": true }` and `{"checked": false}`. This diff updates the serialization of the `accessibilityState` prop for the prop diffing on the View component. This fixes the e2e test selectors for radio buttons. Changelog: [Internal] Differential Revision: D74910744
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
May 17, 2025
…ent (facebook#51420) Summary: The checked and unchecked state of the accessibility state property has to be serialized as `{ "checked": true }` and `{"checked": false}`. This diff updates the serialization of the `accessibilityState` prop for the prop diffing on the View component. This fixes the e2e test selectors for radio buttons. Changelog: [Internal] Differential Revision: D74910744
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
May 17, 2025
…ent (facebook#51420) Summary: The checked and unchecked state of the accessibility state property has to be serialized as `{ "checked": true }` and `{"checked": false}`. This diff updates the serialization of the `accessibilityState` prop for the prop diffing on the View component. This fixes the e2e test selectors for radio buttons. Changelog: [Internal] Differential Revision: D74910744
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
May 17, 2025
…ent (facebook#51420) Summary: The checked and unchecked state of the accessibility state property has to be serialized as `{ "checked": true }` and `{"checked": false}`. This diff updates the serialization of the `accessibilityState` prop for the prop diffing on the View component. This fixes the e2e test selectors for radio buttons. Changelog: [Internal] Differential Revision: D74910744
…ent (facebook#51420) Summary: Pull Request resolved: facebook#51420 The checked and unchecked state of the accessibility state property has to be serialized as `{ "checked": true }` and `{"checked": false}`. This diff updates the serialization of the `accessibilityState` prop for the prop diffing on the View component. This fixes the e2e test selectors for radio buttons. Changelog: [Internal] Differential Revision: D74910744
|
This pull request was exported from Phabricator. Differential Revision: D74910744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The checked and unchecked state of the accessibility state property has to be serialized as
{ "checked": true }and{"checked": false}.This diff updates the serialization of the
accessibilityStateprop for the prop diffing on the View component.This fixes the e2e test selectors for radio buttons.
Changelog: [Internal]
Differential Revision: D74910744