Introduce feature flag for safer main queue sync dispatch #51430
+428
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74940621 |
|
This pull request was exported from Phabricator. Differential Revision: D74940621 |
|
This pull request was exported from Phabricator. Differential Revision: D74940621 |
Summary: Just refactoring the control flow in these functions (in a separate diff). So, that the logic in subsequent diffs is easier to read: D74769326. Note: I made the second argument to RCTUnsafeExecuteOnMainQueueSyncWithError nullable. Changelog: [Internal] Differential Revision: D74940681
Summary: Just refactoring an renaming the variables inside RuntimeExecutor again (in a separate diff). Just so that the logic in the subsequent diffs is easier to read: D74769326 Changelog: [Internal] Differential Revision: D74941734
Summary: We want the ios implementation of this api, to be implemented differently. Because, we need to build in deadlock mitigation for sync renders and events, for ios only. Changelog: [Internal] Differential Revision: D74901907
Summary: Gating for "safer main queue sync dispatch": D74769326 Changelog: [Internal] Differential Revision: D74940621
|
This pull request was exported from Phabricator. Differential Revision: D74940621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gating for "safer main queue sync dispatch": D74769326
Changelog: [Internal]
Differential Revision: D74940621