RuntimeExecutor: Fork an ios implementation #51432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

RSNara wants to merge 1 commit into facebook:main from RSNara:export-D74901907

Contributor

RSNara commented May 17, 2025

Summary:
We want the ios implementation of this api, to be implemented differently. Because, we need to build in deadlock mitigation for sync renders and events, for ios only.

Changelog: [Internal]

Differential Revision: D74901907

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented May 17, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented May 18, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 747ff5f to d0c22cc Compare

May 18, 2025 16:28

Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from d0c22cc to d29edb7 Compare

May 19, 2025 01:02

Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara added a commit to RSNara/react-native that referenced this pull request


          RuntimeExecutor: Fork an ios implementation (facebook#51432)

d08df64

Summary:
Pull Request resolved: facebook#51432

We want the ios implementation of this api, to be implemented differently. Because, we need to build in deadlock mitigation for sync renders and events, for ios only.

Changelog: [Internal]

Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from d29edb7 to d08df64 Compare

May 19, 2025 01:10

Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from d08df64 to f585e4c Compare

May 19, 2025 01:53

Contributor

facebook-github-bot commented May 19, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from f585e4c to bc23993 Compare

May 19, 2025 19:01

Contributor

facebook-github-bot commented May 20, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from bc23993 to 6e32a27 Compare

May 20, 2025 21:17

Contributor

facebook-github-bot commented May 20, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 6e32a27 to 3a08d9d Compare

May 20, 2025 22:41

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 3a08d9d to 0176a10 Compare

May 21, 2025 01:06

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 0176a10 to 65487c5 Compare

May 21, 2025 17:01

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 65487c5 to f1707ad Compare

May 21, 2025 19:56

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from f1707ad to 6bd7030 Compare

May 21, 2025 21:34

RSNara added a commit to RSNara/react-native that referenced this pull request


          RuntimeExecutor: Fork an ios implementation (facebook#51432)

6d7ce4b

Summary:
Pull Request resolved: facebook#51432

RuntimeExecutor.h has sync ui thread utils:
* executeSynchronouslyOnSameThread_CAN_DEADLOCK

The ios platform has js -> ui sync calls. This util, when it executes concurrently with those sync calls, deadlocks react native.

On ios, we're going to resolve these deadlocks, which'll involve customizing this util: D74769326. Therefore, this diff forks an implementation of these sync ui thread utils for ios.

Changelog: [Internal]

Differential Revision: D74901907

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara added a commit to RSNara/react-native that referenced this pull request


          RuntimeExecutor: Fork an ios implementation (facebook#51432)

9dbe561

Summary:
Pull Request resolved: facebook#51432

RuntimeExecutor.h has sync ui thread utils:
* executeSynchronouslyOnSameThread_CAN_DEADLOCK

The ios platform has js -> ui sync calls. This util, when it executes concurrently with those sync calls, deadlocks react native.

On ios, we're going to resolve these deadlocks, which'll involve customizing this util: D74769326. Therefore, this diff forks an implementation of these sync ui thread utils for ios.

Changelog: [Internal]

Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 742c7d0 to 9dbe561 Compare

May 21, 2025 22:47

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 9dbe561 to 31cbadb Compare

May 21, 2025 23:19

Contributor

facebook-github-bot commented May 21, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 31cbadb to cb65832 Compare

May 21, 2025 23:38

RSNara added a commit to RSNara/react-native that referenced this pull request


          RuntimeExecutor: Fork an ios implementation (facebook#51432)

cb65832

Summary:
Pull Request resolved: facebook#51432

RuntimeExecutor.h has sync ui thread utils:
* executeSynchronouslyOnSameThread_CAN_DEADLOCK

The ios platform has js -> ui sync calls. This util, when it executes concurrently with those sync calls, deadlocks react native.

On ios, we're going to resolve these deadlocks, which'll involve customizing this util: D74769326. Therefore, this diff forks an implementation of these sync ui thread utils for ios.

Changelog: [Internal]

Differential Revision: D74901907

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from cb65832 to 94217b2 Compare

May 22, 2025 00:26

Contributor

facebook-github-bot commented May 22, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 94217b2 to 128e466 Compare

May 22, 2025 16:33

Contributor

facebook-github-bot commented May 23, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 128e466 to 65d9886 Compare

May 23, 2025 19:38

Contributor

facebook-github-bot commented May 23, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 65d9886 to 06a5869 Compare

May 23, 2025 22:04

Contributor

facebook-github-bot commented May 24, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 06a5869 to d6705f3 Compare

May 24, 2025 03:25

Contributor

facebook-github-bot commented May 24, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from d6705f3 to f5c39ca Compare

May 24, 2025 04:26

Contributor

facebook-github-bot commented May 27, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from f5c39ca to 456228c Compare

May 27, 2025 16:50

Contributor

facebook-github-bot commented May 28, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 456228c to 7a79778 Compare

May 28, 2025 05:19


          RuntimeExecutor: Create an ios fork of sync ui thread utils (facebook…

bcd0bb6

…#51432)

Summary:
Pull Request resolved: facebook#51432

RuntimeExecutor.h has sync ui thread utils:
* executeSynchronouslyOnSameThread_CAN_DEADLOCK

The ios platform has js -> ui sync calls. This util, when it executes concurrently with those sync calls, deadlocks react native.

On ios, we're going to resolve these deadlocks, which'll involve customizing this util: D74769326. Therefore, this diff forks an implementation of these sync ui thread utils for ios.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D74901907

Contributor

facebook-github-bot commented May 28, 2025

This pull request was exported from Phabricator. Differential Revision: D74901907

RSNara force-pushed the export-D74901907 branch from 7a79778 to bcd0bb6 Compare

May 28, 2025 05:28

Collaborator

react-native-bot commented Nov 24, 2025

This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.

react-native-bot added Stale and removed Stale labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported p: Facebook Partner