Cleanup custom LOG_TAG in our CMakeLists files. #51622
Closed
+78
−280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: RNTester Android is currently instacrashing in OSS due to 3rd-party packages not having the `RN_SERIALIZABLE_STATE` definition. That's because the `INTERFACE` definition is not properly propagated on the prefab boundaries. This was happening for `react-native-popup-menu-android` and `react-native-test-library` and will also happen for Codegen libraries. This fixes it. 3p developers with custom CMake files will also have to use the `target_compile_reactnative_options` functions to make sure the compilation flag are properly populated. Changelog: [Android] [Changed] - Correctly propagate RN_SERIALIZABLE_STATE to 3rd party CMake targets Differential Revision: D75441245
Summary: We currently support an optional 3rd params for `target_compile_reactnative_options` which allows to specify a LOG_TAG macro. No one is actually reading that Macro. The only usage would be logging from the Android SDK which we don't explicitely use. Here I'm updating our build to specify a LOG_TAG as `ReactNative` for all the targets without allowing to customize it as it just complicates our build setup. Changelog: [Internal] [Changed] - Differential Revision: D75445577
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75445577 |
|
This pull request has been merged in a6f24a5. |
|
This pull request was successfully merged by @cortinico in a6f24a5 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We currently support an optional 3rd params for
target_compile_reactnative_optionswhich allows to specify a LOG_TAG macro.No one is actually reading that Macro. The only usage would be logging from the Android SDK which we don't explicitely use.
Here I'm updating our build to specify a LOG_TAG as
ReactNativefor all the targets without allowing to customize it as it just complicates our build setup.Changelog:
[Internal] [Changed] -
Differential Revision: D75445577