Let accessible be std::optional in native #51630
Open
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We want to change Text so that if it has links, and no `accessible` value set, it becomes accessible by default for keyboards. To do that we need native to know if "no value is set". This means changing from a `bool` to a `std::optional<bool>`. This diff does that and fixes any build errors. Runtime should be the same, since the default at all the callsites is false (the default before), and JS overrides will still apply. Changelog: [Internal] Reviewed By: javache Differential Revision: D74914316
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74914316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to change Text so that if it has links, and no
accessiblevalue set, it becomes accessible by default for keyboards. To do that we need native to know if "no value is set". This means changing from aboolto astd::optional<bool>.This diff does that and fixes any build errors. Runtime should be the same, since the default at all the callsites is false (the default before), and JS overrides will still apply.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D74914316