Fix crash in view culling when view is unflattened/flattened in deep hierarchy where each node has top offset #51639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75455704 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 27, 2025
…hierarchy where each node has top offset (facebook#51639) Summary: changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
sammy-SC
force-pushed
the
export-D75455704
branch
from
62b63fd to
7b7df25
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 27, 2025
…hierarchy where each node has top offset (facebook#51639) Summary: changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
sammy-SC
force-pushed
the
export-D75455704
branch
from
7b7df25 to
ecec444
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75455704 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 27, 2025
…hierarchy where each node has top offset (facebook#51639) Summary: Pull Request resolved: facebook#51639 changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
sammy-SC
force-pushed
the
export-D75455704
branch
from
ecec444 to
5624d84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75455704 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 27, 2025
…hierarchy where each node has top offset (facebook#51639) Summary: Pull Request resolved: facebook#51639 changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
sammy-SC
force-pushed
the
export-D75455704
branch
2 times, most recently
from
fd4bb5a to
142a9c6
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 28, 2025
…hierarchy where each node has top offset (facebook#51639) Summary: changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
…hierarchy where each node has top offset (facebook#51639) Summary: Pull Request resolved: facebook#51639 changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
|
This pull request was exported from Phabricator. Differential Revision: D75455704 |
sammy-SC
force-pushed
the
export-D75455704
branch
from
142a9c6 to
cf91e0c
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 28, 2025
…hierarchy where each node has top offset (facebook#51639) Summary: changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
May 28, 2025
…hierarchy where each node has top offset (facebook#51639) Summary: changelog: [internal] ### Fix Crash in View Culling This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset. The problem is that nodes passed to *calculateShadowViewMutationsFlattener* via argument *unvisitedOtherNodes* have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to *calculateShadowViewMutationsFlattener* which does have original view culling context with which these nodes had their position calculated. Reviewed By: javache Differential Revision: D75455704
|
This pull request was successfully merged by @sammy-SC in 66730ae When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 66730ae. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Fix Crash in View Culling
This diff fixes a crash that occurs when a view is unflattened or flattened in a deep hierarchy where each node has a top offset.
The problem is that nodes passed to calculateShadowViewMutationsFlattener via argument unvisitedOtherNodes have their positions calculated in a different coordinate space and the view culling algorithm does not have the correct data to determine visibility of a node. To fix this, we pass another argument to calculateShadowViewMutationsFlattener which does have original view culling context with which these nodes had their position calculated.
Differential Revision: D75455704