jsi | remove redundant semi colon #51651
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75478125 |
arhelmus
added a commit
to arhelmus/hermes
that referenced
this pull request
May 27, 2025
Summary: X-link: facebook/react-native#51651 this breaks certain compilers/build setups in cpp Differential Revision: D75478125
arhelmus
added a commit
to arhelmus/hermes
that referenced
this pull request
May 27, 2025
Summary: X-link: facebook/react-native#51651 this breaks certain compilers/build setups in cpp Differential Revision: D75478125
arhelmus
added a commit
to arhelmus/react-native
that referenced
this pull request
May 27, 2025
Summary: X-link: facebook/hermes#1715 this breaks certain compilers/build setups in cpp Differential Revision: D75478125
arhelmus
force-pushed
the
export-D75478125
branch
from
e770640 to
0de7224
Compare
Summary: X-link: facebook/hermes#1715 Pull Request resolved: facebook#51651 this breaks certain compilers/build setups in cpp Differential Revision: D75478125
arhelmus
added a commit
to arhelmus/hermes
that referenced
this pull request
May 27, 2025
Summary: Pull Request resolved: facebook#1715 X-link: facebook/react-native#51651 this breaks certain compilers/build setups in cpp Differential Revision: D75478125
|
This pull request was exported from Phabricator. Differential Revision: D75478125 |
arhelmus
force-pushed
the
export-D75478125
branch
from
0de7224 to
df7b3df
Compare
arhelmus
added a commit
to arhelmus/hermes
that referenced
this pull request
May 27, 2025
Summary: Pull Request resolved: facebook#1714 Pull Request resolved: facebook#1715 X-link: facebook/react-native#51651 this breaks certain compilers/build setups in cpp Differential Revision: D75478125
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
May 28, 2025
Summary: Pull Request resolved: #1714 Pull Request resolved: #1715 X-link: facebook/react-native#51651 this breaks certain compilers/build setups in cpp Reviewed By: NickGerleman Differential Revision: D75478125 fbshipit-source-id: d5a9db25ebeecb229e157babf2117e8a2096e0d2
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
May 28, 2025
Summary: Pull Request resolved: #1714 Pull Request resolved: #1715 X-link: facebook/react-native#51651 this breaks certain compilers/build setups in cpp Reviewed By: NickGerleman Differential Revision: D75478125 fbshipit-source-id: d5a9db25ebeecb229e157babf2117e8a2096e0d2
|
This pull request has been merged in 17f1d91. |
|
This pull request was successfully merged by @arhelmus in 17f1d91 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been reverted by 56c1ab3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: this breaks certain compilers/build setups in cpp
Differential Revision: D75478125