RN: Flowify packages/react-native/jest
#51652
Closed
+578
−438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 27, 2025
Summary: Adds `flow` (or `noflow`) to all files in this directory and ensures that Flow succeeds (by adding type annotations, using minor refactors, or suppressing errors due to intentionally dynamic logic). This will help improve type safety when making changes both in these files as well as files that these depend on. ## Changelog: [Internal] Test Plan: Ran Flow and Jest tests successfully: ``` $ yarn flow $ yarn test ``` Differential Revision: D75488160 Pulled By: yungsters
|
This pull request was exported from Phabricator. Differential Revision: D75488160 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
May 27, 2025
Summary: Adds `flow` (or `noflow`) to all files in this directory and ensures that Flow succeeds (by adding type annotations, using minor refactors, or suppressing errors due to intentionally dynamic logic). This will help improve type safety when making changes both in these files as well as files that these depend on. ## Changelog: [Internal] Test Plan: Ran Flow and Jest tests successfully: ``` $ yarn flow $ yarn test ``` Differential Revision: D75488160 Pulled By: yungsters
|
This pull request was exported from Phabricator. Differential Revision: D75488160 |
Summary: Adds `flow` (or `noflow`) to all files in this directory and ensures that Flow succeeds (by adding type annotations, using minor refactors, or suppressing errors due to intentionally dynamic logic). This will help improve type safety when making changes both in these files as well as files that these depend on. ## Changelog: [Internal] Test Plan: Ran Flow and Jest tests successfully: ``` $ yarn flow $ yarn test ``` Ran a Jest unit test internally to make sure they work with our internal environment setup: ``` $ cd ~/fbsource $ js1 test /View-test.js ``` Reviewed By: javache Differential Revision: D75488160 Pulled By: yungsters
|
This pull request was exported from Phabricator. Differential Revision: D75488160 |
|
This pull request was successfully merged by @yungsters in a4c2007 When will my fix make it into a release? | How to file a pick request? |
|
@yungsters merged this pull request in a4c2007. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
@flow(or@noflow) to all files in this directory and ensures that Flow succeeds (by adding type annotations, using minor refactors, or suppressing errors due to intentionally dynamic logic).This will help improve type safety when making changes both in these files as well as files that these depend on.
Changelog:
[Internal]
Test Plan:
Ran Flow and Jest tests successfully: