perf: Move func into CallInvoker::invokeAsync

[mrousavy]

Summary:

Instead of copying the std::function into invokeAsync, we now move it.

Changelog:

[GENERAL] [CHANGED] - Move std::function into CallInvoker::invokeAsync instead of copying it

Test Plan:

Build, run. A lot of code still uses the old invokeAsync function.

[mrousavy]

On another note; do you think we should mark the "old" invokeAsync/invokeSync functions [[deprecated]] and try to move everyone to the new functions?

Right now the old functions just schedule anything under SchedulerPriority::ImmediatePriority (the highest priority), which of course is sub-optimal for anyone else actually respecting the SchedulerPriority APIs.

Ideally the categories should be:

• SchedulerPriority::IdlePriority:
  • ??
• SchedulerPriority::LowPriority:
  • ??
• SchedulerPriority::NormalPriority:
  • Async JS callbacks
• SchedulerPriority::UserBlockingPriority
  • Promise resolve/reject
  • setTimeout
• SchedulerPriority::ImmediatePriority
  • requestAnimationFrame

[javache]

Thanks! Agree that it would make sense to deprecate the other variants, but we should probably improve docs first on what to use each priority for.

[meta-codesync]

@javache has imported this pull request. If you are a Meta employee, you can view this in D84563949.