[0.85] Skip prebuilds for DynamicFrameworks CI jobs#56645
Open
motiz88 wants to merge 1 commit intofacebook:0.85-stablefrom
Open
[0.85] Skip prebuilds for DynamicFrameworks CI jobs#56645motiz88 wants to merge 1 commit intofacebook:0.85-stablefrom
motiz88 wants to merge 1 commit intofacebook:0.85-stablefrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapted cherry-pick of 3770421e960 (#56593) from
0.83-stable.Adds
if: != DynamicFrameworksguards to the prebuild download steps in the helloworld CI action, and moves the prebuild env var exports into theelsebranch so they are only set when not using DynamicFrameworks.On 0.85, the rntester action already has stricter guards (
== false), and the prebuild workflow already uses the version.properties-based Hermes detection pattern, so only the helloworld action needed changes.This commit does not exist on
main— it may need a separate forward-port there. See notes in the pick request.Changelog:
[Internal]
Test Plan
cc @cipolleschi