feat: add eslint-plugin-react-compiler
#227
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecreeth
commented
Oct 24, 2024
| "react-hooks/exhaustive-deps": "error", | ||
|
|
||
| // react-compiler | ||
| "react-compiler/react-compiler": "warn" |
There was a problem hiding this comment.
warn until all fixes has been applied.
|
The benchmarks/{size, perf} jobs are failing because of this: See more in peter-evans/create-or-update-comment#76 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #216
Currently, we're doing a lot of
nativeProps.PROP = VALUE;assignments and the compiler doesn't like at all. It throws:I fixed it by doing shallow copies, but I don't know if this is the right approach. If this is ok I can continue doing the rest.
Tried to dig dive a little and found this: facebook/react#29093 (comment)