Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default accessibility roles to native elements #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Mar 25, 2025

Adds default role values for certain tags on native

Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

Results Base Patch Ratio
react-strict-dom/dist/dom/index.js
· compressed 2,515 2,515 1.00
· minified 8,688 8,688 1.00
react-strict-dom/dist/dom/runtime.js
· compressed 855 855 1.00
· minified 2,435 2,435 1.00
react-strict-dom/dist/native/index.js
· compressed 15,895 15,969 1.00 +
· minified 59,490 59,663 1.00 +

Copy link

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better.

Results Base Patch Ratio
css.create
· small 1,109,977 1,121,289 1.01 +
· small with units 438,193 441,684 1.01 +
· small with variables 672,965 671,397 1.00 -
· several small 320,169 321,797 1.01 +
· large 205,847 211,347 1.03 +
· large with polyfills 146,115 148,361 1.02 +
· complex 99,569 100,683 1.01 +
· unsupported 217,026 220,962 1.02 +
css.createTheme
· simple theme 229,161 232,588 1.01 +
· polyfill theme 219,533 220,090 1.00 +
css.props
· small 238,975 238,917 1.00 -
· small with units 186,412 187,681 1.01 +
· small with variables 104,287 104,914 1.01 +
· small with variables of units 73,759 74,468 1.01 +
· large 101,233 102,602 1.01 +
· large with polyfills 36,673 36,889 1.01 +
· complex 23,435 23,629 1.01 +
· unsupported 148,760 147,643 0.99 -
· simple merge 160,905 160,950 1.00 +
· wide merge 17,771 17,693 1.00 -
· deep merge 17,438 17,238 0.99 -
· themed merge 31,515 31,608 1.00 +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants