Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use correct actor when checking if maintainer #32112

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[ci] Use correct actor when checking if maintainer #32112

merged 1 commit into from
Jan 17, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Jan 17, 2025

The discord notification workflows were checking the label event's actor (ie a bot) instead of the pull request's actor. To fix this, parameterize the shared maintainer check workflow and always use the pull request user as the input.

The discord notification workflows were checking the label event's actor (ie a bot) instead of the pull request's actor. To fix this, parameterize the shared maintainer check workflow and always use the pull request user as the input.
@react-sizebot
Copy link

Comparing: 7f3826e...6854a73

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.74 kB 91.74 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 556.18 kB = 98.72 kB 98.72 kB
facebook-www/ReactDOM-prod.classic.js = 595.79 kB 595.79 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 586.21 kB 586.21 kB = 103.30 kB 103.30 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ffb759a

@poteto poteto merged commit 77656c5 into main Jan 17, 2025
195 checks passed
@poteto poteto deleted the pr32112 branch January 17, 2025 17:42
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants