Stop exporting dev-only methods in production builds #32200
+166
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: ae9017c...ddfb804 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
eps1lon
commented
Jan 23, 2025
There was a problem hiding this comment.
Copy of index.stable.js + act
eps1lon
commented
Jan 23, 2025
There was a problem hiding this comment.
Copy of index.fb.js + act + captureOwnerStack
eps1lon
commented
Jan 23, 2025
| @@ -571,7 +571,7 @@ function shouldSkipBundle(bundle, bundleType) { | |||
| return false; | |||
| } | |||
|
|
|||
| function resolveEntryFork(resolvedEntry, isFBBundle) { | |||
| function resolveEntryFork(resolvedEntry, isFBBundle, isDev) { | |||
There was a problem hiding this comment.
Third arg was always passed but not utilized until now.
eps1lon
force-pushed
the
dev-is-dev
branch
2 times, most recently
from
730b540 to
6a60f6d
Compare
eps1lon
commented
Jan 23, 2025
| @@ -779,13 +779,5 @@ function runActTests(render, unmount, rerender) { | |||
| }); | |||
| } | |||
| }); | |||
| describe('throw in prod mode', () => { | |||
There was a problem hiding this comment.
Replaced by the test in packages/react-reconciler/src/__tests__/ReactIsomorphicAct-test.js. This is testing React.act not react-dom/test-utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Affects OSS and FB builds.
The development entrypoints were setup in #29923 but they were always used i.e. they effectively replaced the standard entrypoints. Now we only use the
.development.jsentrypoints for dev builds.It's technically a bug fix though it might be too invasive to do now for
act. We can definitely do it forcaptureOwnerStackthough.How did you test this change?
yarn build react/index --type NODE_PROD,NODE_ENVno longer containsexports.actandexports.captureOwnerStackin~/cjs/react.production.jswhile~/cjs/react.development.jsstill has these exportscc @sebmarkbage