[Fiber][Dev] Relax dom nesting validation when the root is a Document, html tag, or body tag #32252
+175
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
gnoff
changed the title
gnoff
changed the title
|
Comparing: b48e739...365cde6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
aee09bb to
163de10
Compare
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
163de10 to
8d78e37
Compare
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
8d78e37 to
aa7b5bd
Compare
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
aa7b5bd to
c30cf4c
Compare
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
4 times, most recently
from
c15858c to
2d56804
Compare
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
2d56804 to
8ebfb85
Compare
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
8ebfb85 to
ecf43ac
Compare
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
ecf43ac to
49e0fae
Compare
eps1lon
approved these changes
Feb 6, 2025
| @@ -138,6 +164,49 @@ describe('validateDOMNesting', () => { | |||
| 'In HTML, <body> cannot be a child of <body>.\n' + | |||
| 'This will cause a hydration error.\n' + | |||
| ' in body (at **)', | |||
| 'You are mounting a new body component when a previous one has not first unmounted.', | |||
There was a problem hiding this comment.
Any chance we can skip this when we already warned about body > body?
in react-dom in Dev we validate that the tag nesting is valid. This is motivated primarily because while browsers are tolerant to poor HTML there are many cases that if server rendered will be hydrated in a way that will break hydration. With the changes to singleton scoping where the document body is now the implicit render/hydration context for arbitrary tags at the root we need to adjust the validation logic to allow for valid programs such as rendering divs as a child of a Document (since this div will actually insert into the body).
gnoff
force-pushed
the
relax-dom-nesting-at-root
branch
from
49e0fae to
0a749ef
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
…, html tag, or body tag (#32252) followup to * #32069 * #32163 * #32224 in react-dom in Dev we validate that the tag nesting is valid. This is motivated primarily because while browsers are tolerant to poor HTML there are many cases that if server rendered will be hydrated in a way that will break hydration. With the changes to singleton scoping where the document body is now the implicit render/hydration context for arbitrary tags at the root we need to adjust the validation logic to allow for valid programs such as rendering divs as a child of a Document (since this div will actually insert into the body). DiffTrain build for [a0fdb63](a0fdb63)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
…, html tag, or body tag (#32252) followup to * #32069 * #32163 * #32224 in react-dom in Dev we validate that the tag nesting is valid. This is motivated primarily because while browsers are tolerant to poor HTML there are many cases that if server rendered will be hydrated in a way that will break hydration. With the changes to singleton scoping where the document body is now the implicit render/hydration context for arbitrary tags at the root we need to adjust the validation logic to allow for valid programs such as rendering divs as a child of a Document (since this div will actually insert into the body). DiffTrain build for [a0fdb63](a0fdb63)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Feb 7, 2025
…, html tag, or body tag (facebook#32252) followup to * facebook#32069 * facebook#32163 * facebook#32224 in react-dom in Dev we validate that the tag nesting is valid. This is motivated primarily because while browsers are tolerant to poor HTML there are many cases that if server rendered will be hydrated in a way that will break hydration. With the changes to singleton scoping where the document body is now the implicit render/hydration context for arbitrary tags at the root we need to adjust the validation logic to allow for valid programs such as rendering divs as a child of a Document (since this div will actually insert into the body). DiffTrain build for [a0fdb63](facebook@a0fdb63)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Feb 7, 2025
…, html tag, or body tag (facebook#32252) followup to * facebook#32069 * facebook#32163 * facebook#32224 in react-dom in Dev we validate that the tag nesting is valid. This is motivated primarily because while browsers are tolerant to poor HTML there are many cases that if server rendered will be hydrated in a way that will break hydration. With the changes to singleton scoping where the document body is now the implicit render/hydration context for arbitrary tags at the root we need to adjust the validation logic to allow for valid programs such as rendering divs as a child of a Document (since this div will actually insert into the body). DiffTrain build for [a0fdb63](facebook@a0fdb63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to
in react-dom in Dev we validate that the tag nesting is valid. This is motivated primarily because while browsers are tolerant to poor HTML there are many cases that if server rendered will be hydrated in a way that will break hydration.
With the changes to singleton scoping where the document body is now the implicit render/hydration context for arbitrary tags at the root we need to adjust the validation logic to allow for valid programs such as rendering divs as a child of a Document (since this div will actually insert into the body).