-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin-react-hooks): remove experimental checks involving useEffectEvent #32276
Open
michaelfaith
wants to merge
1
commit into
facebook:main
Choose a base branch
from
michaelfaith:fix/remove-experimental-eslint-rule-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(eslint-plugin-react-hooks): remove experimental checks involving useEffectEvent #32276
michaelfaith
wants to merge
1
commit into
facebook:main
from
michaelfaith:fix/remove-experimental-eslint-rule-checks
+2
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…useEffectEvent Contributing to facebook#32240, this change removes the experimental `useEffectEvent` checks in the two react hooks eslint rule. As the api is refined, and the compiler rule(s) are incorporated into this plugin, these checks will be covered then.
michaelfaith
force-pushed
the
fix/remove-experimental-eslint-rule-checks
branch
from
January 31, 2025 00:46
02c1846
to
2a91f47
Compare
poteto
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributing to #32240, this change removes the experimental
useEffectEvent
checks in the two react hooks ESLint rules. As the api is refined, and the compiler rule(s) are incorporated into this plugin, these checks will be covered then.