Fix typo in dangerfile.js which results in an unreachable code path… #32277
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix typo in dangerfile.js which results in an unreachable code path which ought to be hit when there is no matching base artifact during DangerCI automated code review.
See:
react/dangerfile.js
Line 73 in 221f300
Compare:
react/dangerfile.js
Line 171 in 221f300
And the case which should hit this code path:
react/dangerfile.js
Line 160 in 221f300
Given the above context, the condition
Number === Infinity
is clearly meant to bedecimal === Infinity
, which it will be if thecatch
statement triggers when there is no matching base artifact. Without this fix, the primitive valueInfinity
is passed topercentFormatter.format(decimal)
, resulting in the string'+∞%'
. With this fix, the resulting string will be the intended'New file'
.Resolves issue 32278