build(eslint-plugin-react-hooks): add dev dependencies for typescript migration #32279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Comparing: 9ff42a8...1be7a03 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
michaelfaith
force-pushed
the
build/add-new-eslint-plugin-deps
branch
from
c10aee7 to
b5b795d
Compare
poteto
approved these changes
Jan 31, 2025
| "eslint-v9": "npm:eslint@^9.0.0" | ||
| "eslint-v9": "npm:eslint@^9.0.0", | ||
| "jest": "^29.5.0", | ||
| "tsup": "^8.3.5", |
There was a problem hiding this comment.
Suggested change
| "tsup": "^8.3.5", | |
| "tsup": "^8.3.5", |
There was a problem hiding this comment.
How weird. I wonder why my IDE didn't pick up the repo's prettier settings in this one line 😅 I've fixed it.
… migration Contributing to facebook#32240, this change adds the dev dependencies needed to support the migration of the plugin to typescript.
michaelfaith
force-pushed
the
build/add-new-eslint-plugin-deps
branch
from
b5b795d to
cadae64
Compare
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributing to #32240, this change adds the dev dependencies needed to support the migration of the plugin to typescript.